fix: merge duplicate findings for the same package from multiple advisory sources - #1076
Merged
Conversation
sonukapoor
force-pushed
the
feature/dedup-findings-by-source
branch
from
September 5, 2026 15:15
89abb57 to
184336a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the same package could appear as two separate rows in all outputs (compact, verbose, HTML, JSON, SARIF) when both OSV and the npm supplemental advisory pass returned advisories for it with different IDs.
Adds a
mergeResultsByPackagehelper insrc/scanner.tsthat collapses the flat results array byname@versionbefore findings are created, so all vuln IDs from both sources land in a single Finding. The dedup guard inside the helper also prevents double-counting if the same ID ever appears from both sources.Also widens the Type column in the HTML report findings table so "direct · dev" badges have more breathing room.
Closes #1075