Feature/eks container path fixes - #24
Open
KamalCharles wants to merge 4 commits into
Open
Conversation
Update drought and TC ibtracs simulation scripts plus app.R mapping/ python source paths to use absolute /srv/shiny-server paths expected in the EKS container, and revert the ShinyProxy deployment image tag from v1-logo-fix back to latest now that the fix is baked into the default image.
Capture the shinyproxy-restart CronJob (with its ServiceAccount, Role, and RoleBinding) and the shinyproxy-hpa HorizontalPodAutoscaler that were applied directly to the cluster, so autoscaling and the scheduled restart are tracked in the repo. Also remove sp-deployment-serviceaccount.yaml, a stale duplicate Deployment definition left over from an old branch merge that no longer matches the live shinyproxy-new deployment.
Rename sp-deployment-new.yaml, sp-service-new.yaml, and sp-service-new-risk.yaml to sp-deployment.yaml, sp-service.yaml, and sp-service-risk.yaml for clarity. File names only — the underlying Kubernetes resource names (e.g. shinyproxy-new) are unchanged, so there's no impact on the live cluster.
The riskexplorer-service targetPort still pointed at 3838 (pre-ShinyProxy migration) instead of 8080, causing Cloudflare 520s. Session pods also had no CPU/memory requests/limits, letting nodes get overpacked and OOM. Also patches the ShinyProxy tab title and points sp-deployment.yaml at the oasislmf-resource-limits image actually running in the cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Sync EKS config with live cluster state and fix container paths
Body:
Summary
Test plan
kubectl getoutput for shinyproxy-new deployment, hpa, and cronjob in the shiny namespace