Skip to content

*: fix potential code injection - #4598

Merged
KaloyanTanev merged 1 commit into
mainfrom
kalo/fix-workflows-interpolation
Jul 14, 2026
Merged

*: fix potential code injection#4598
KaloyanTanev merged 1 commit into
mainfrom
kalo/fix-workflows-interpolation

Conversation

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

As per the title

category: bug
ticket: none

@KaloyanTanev
KaloyanTanev requested a review from pinebit July 14, 2026 09:18
@KaloyanTanev KaloyanTanev self-assigned this Jul 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.60%. Comparing base (cd96ee2) to head (c3c93f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4598      +/-   ##
==========================================
+ Coverage   57.58%   57.60%   +0.01%     
==========================================
  Files         246      246              
  Lines       33675    33675              
==========================================
+ Hits        19392    19397       +5     
  Misses      11843    11843              
+ Partials     2440     2435       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the patch-release GitHub Actions workflows to reduce the risk of expression/input-driven shell injection when propagating the target_minor workflow input into bash scripts.

Changes:

  • Pass inputs.target_minor via a step env variable (TARGET_MINOR_INPUT) instead of interpolating the expression directly inside the run: script.
  • Update the bash assignment to use TARGET_MINOR="$TARGET_MINOR_INPUT" across patch-release steps 1–4.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/patch-release-step1.yml Routes target_minor through env before using it in the version bump script to reduce injection risk.
.github/workflows/patch-release-step2.yml Routes target_minor through env before using it in the branch selection logic to reduce injection risk.
.github/workflows/patch-release-step3.yml Routes target_minor through env before using it in the branch selection logic to reduce injection risk.
.github/workflows/patch-release-step4.yml Routes target_minor through env before using it in the branch selection logic to reduce injection risk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KaloyanTanev
KaloyanTanev merged commit 68d31b9 into main Jul 14, 2026
12 checks passed
@KaloyanTanev
KaloyanTanev deleted the kalo/fix-workflows-interpolation branch July 14, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants