test: add coverage for includeStatus parameter

[3rabiii]

Description

This PR addresses the missing test coverage for the includeStatus query parameter in the trips-for-route handler.

Changes Made

• Added a new table-driven test TestTripsForRouteHandler_StatusInclusion in internal/restapi/trips_for_route_handler_test.go.
• The test explicitly verifies that:
  • includeStatus=false correctly omits the status object from the response entries.
  • includeStatus=true (or omitted) correctly includes the populated status object.

Closes: #1292

Summary by CodeRabbit

• Tests
  • Added coverage to verify trip responses correctly include or omit status information based on the includeStatus setting.
  • Confirmed default and explicitly enabled behavior returns valid status details for active trips.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b512cca8-e904-4f0f-a89a-ca5bc8fde5dc

📥 Commits

Reviewing files that changed from the base of the PR and between 3b73fd9 and 9268bda.

📒 Files selected for processing (1)

• internal/restapi/trips_for_route_handler_test.go

---

📝 Walkthrough

Walkthrough

Added table-driven tests for the trips-for-route handler. The tests verify default, explicit, and disabled includeStatus behavior, including valid status phases and omitted status data.

Changes

Trips-for-route status behavior

Layer / File(s)	Summary
Status inclusion test coverage internal/restapi/trips_for_route_handler_test.go	Adds table-driven cases for default and explicit includeStatus inclusion and for includeStatus=false. The tests verify populated status data, active trip IDs, valid phases, and omitted status data.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• OneBusAway/maglev#1145: Adds related status-inclusion tests for a different REST trip handler.
• OneBusAway/maglev#1217: Adds query-parameter inclusion tests in the same handler.
• OneBusAway/maglev#1233: Tests status-inclusion parsing behavior in the same API area.

Suggested reviewers: ahmedhossamdev, burma-shave, aaronbrethorst

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the added test coverage for the includeStatus parameter.
Linked Issues check	✅ Passed	The test covers omitted, enabled, and disabled includeStatus behavior and verifies status omission or populated status data as required by [#1292].
Out of Scope Changes check	✅ Passed	The pull request changes only the handler test file and adds coverage directly related to the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud