Skip to content

fix: derive web_push_topic from the post ID - #431

Merged
sherwinski merged 2 commits into
mainfrom
fix/web-push-topic-based-on-content
Jul 2, 2026
Merged

fix: derive web_push_topic from the post ID#431
sherwinski merged 2 commits into
mainfrom
fix/web-push-topic-based-on-content

Conversation

@marclucraft

Copy link
Copy Markdown
Contributor

Currently $segment is used.

Each post will now have its own unique topic, so notifications for different posts won't override each other.

Internal ticket

Comment thread v3/onesignal-notification.php Outdated
@marclucraft

marclucraft commented Jun 28, 2026 via email

Copy link
Copy Markdown
Contributor Author

@sherwinski
sherwinski force-pushed the fix/web-push-topic-based-on-content branch from 0b14266 to 7e20162 Compare July 2, 2026 18:50
@sherwinski
sherwinski force-pushed the fix/web-push-topic-based-on-content branch from 7e20162 to 122c0c8 Compare July 2, 2026 18:56
@sherwinski sherwinski changed the title Generate web_push_topic from $content (the post title). fix: derive web_push_topic from the post ID Jul 2, 2026
@sherwinski
sherwinski merged commit fd1b7fd into main Jul 2, 2026
9 of 10 checks passed
@sherwinski
sherwinski deleted the fix/web-push-topic-based-on-content branch July 2, 2026 18:58
@github-actions github-actions Bot mentioned this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants