Keep runtime-thread Invoke rejection enabled in Release builds - #8
Merged
Merged
Conversation
Set the thread-local marker outside debug_assert and run the unchanged test suite in both Debug and Release in CI. Fixes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7.
RuntimeThreadGuard::enter()previously performedmarker.replace(true)insidedebug_assert!. Release builds omit that expression, so runtime-thread Invoke requests bypassed the existing fail-fast admission check.version.No ABI, protocol revision, runtime fallback, or package activation behavior changes.
Validation
Local environment: Windows 11 ARM64, Rust 1.98.1.
400f48f, the existing isolated regression passed in Debug and failed in Release (success: true, expectedfalse). It passes in Release after the fix.--no-default-features --features ffi --all-targets) passed: 486 passed, 4 intentionally ignored. Follow-on poisoned-mutex failures are gone.--all-features --lib --bins -- -D warnings) passed.Representative regression command:
No application installation, live VPN, or Apple/Android physical-device acceptance was performed. Local results above are ARM64; CI provides the separate native x64 coverage.