feat: support llm_config BYOK on jobs and retrieval#33
Merged
Conversation
Expose optional text/vision OpenAI-compatible credentials on job create, parse, and retrieval.query so callers can drive KNOWHERE with their own keys. Co-authored-by: Cursor <cursoragent@cursor.com>
7 tasks
Document that missing text/vision slots keep server defaults instead of acting as a unified multimodal fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
Document and type the shared provider slot for single multimodal BYOK. Co-authored-by: Cursor <cursoragent@cursor.com>
Document flat multimodal shorthand and split text/vision endpoints. Co-authored-by: Cursor <cursoragent@cursor.com>
Support shared auth with different text/vision model ids. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMConfig/LLMProviderConfig/LLMModelsConfigand threadllm_configthrough jobs / parse / retrieval.{api_key, model, base_url}for multimodal;modelsfor same-endpoint different model ids;text/visionfor different endpoints.Depends on: Ontos-AI/knowhere#217
Usage
Test plan
pytest tests/test_jobs.py tests/test_retrieval.py tests/test_parse.py