Template new entrant regional granularity - #134
Draft
EllieKallmier wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to collapse (aggregate) new entrant technologies to the model config's
regional_granularity.Changes live here:
Notes
weighted average that implicitly compensates for this, it drops the known rows by name and
_assert_no_unexpected_duplicate_optionsraises on any other repeat (unexpected). Documented in comments on new_entrants_summary v7.5/7.8: NSA pumped-hydro rows have mismatched Regional build cost zone (CSA instead of NSA) [+workbook weirdness] #131.fuel_price_mappingdropped fromgenerators_new_entrantentirely, rather than carried through the collapse. It's not needed until fuel price templating exists - plan is to match fuel prices viageo_id+technologyagainst a redesignedcosts_fuel_pricestable, now made easier/a more viable option with the planned wild-card schema thing. Two schemas will need matching updates when that happens:costs_fuel_prices.yamlandgenerators_existing_planned.yaml."{geo_id} {technology}", except BOTN - Cethana, which keeps its real name.Follow-ups for later
costs_fuel_prices.yaml/generators_existing_planned.yamlfuel-price-mapping rework (might also rely a bit on Translate the new-format network tables to buses and links #126 and the wildcard handling to properly settle this)N0/V0("Non-REZ" IDs for NSW/VIC) are used asgeo_idbut never appear inrenewable_energy_zones, so they're absent fromnetwork_geographyat every granularity — tracked as Non-REZ IDs N0/V0 not templated in network_geography #133, set out as a known exception in the CLI test.