fix: doublage not cumulated with ITE/ITI isolation - #174
Open
elliot-redfroggy wants to merge 1 commit into
Open
Conversation
According to 3CL method and LICIEL behavior, when a wall has a doublage and an ITE or ITI isolation, the doublage must NOT be included in the Umur0 calculation. The doublage is only counted in the following cases: - non-insulated wall - ITR isolation only - unknown isolation type Isolation types with ITE or ITI affected: ITI (3), ITE (4), ITI+ITE (6), ITI+ITR (7), ITE+ITR (8). Fix applied in both implementations: - src/3.2.1_mur.js (legacy) - src/features/engine/domain/enveloppe/mur/deperdition-mur.service.js Closes Open3CL#146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Selon la méthode 3CL et le comportement de LICIEL, lorsqu'un doublage est présent en même temps qu'une isolation ITE ou ITI, le doublage ne doit pas être pris en compte dans le calcul de Umur0.
Actuellement, le calcul cumule à tort le doublage avec l'isolation ITE/ITI :
Il faut désormais ignorer le doublage quand une isolation ITE ou ITI est présente :
Solution
Le doublage n'est pris en compte que si le type d'isolation ne contient pas d'ITE ni d'ITI :
Modifications
src/3.2.1_mur.js(legacy)src/features/engine/domain/enveloppe/mur/deperdition-mur.service.jssrc/3.2.1_mur.spec.jsCloses #146