Promote to prod: third welcome card opens FAQ panel + send icon + gu spacing fix - #138
Merged
Conversation
Keep the first two pinned questions, and route the fixed "More Useful Questions" card to the settings FAQ list instead of sending a chat prompt. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit b76f36a)
The third welcome card opens the settings FAQ list instead of sending its prompt to the agent, but nothing on the card signalled that. Add the same red Send glyph the FAQ rows already use (settings-drawer.tsx), right-anchored, on that card only — the other four keep their plain layout. The icon is wrapped in a span because Button's `size: default` variant carries `has-[>svg]:px-3`; a bare svg child shrinks the card's horizontal padding and shifts it ~11px left of its neighbours. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the third-welcome-card work from
amul-devtoamul-prod.What ships
b69ace5-xofb76f36a(#131), clean.9009156moreUsefulQuestionsmissing space:વધુઉપયોગી→વધુ ઉપયોગી.3d0181cSendicon right-anchored on that card only, so the panel-opener has an affordance.Notes
hi.jsonhalf of dev's6cbbc8bis deliberately excluded — Hindi is not in prod'sconfig.jsonlanguages and prod'shi.jsonis still the pre-Enable Hindi language #132 file. This PR is en/gu only.settings-drawer.tsx(h-4 w-4 text-[#F65151]), so the card matches the list it opens.<span>on purpose:Button'ssize: defaultvariant carrieshas-[>svg]:px-3, so a bare<svg>child overrides the card'spx-4 sm:px-6and shifts it ~11px left of the other four cards. There's a code comment saying so.Verification
Ran locally against
api.dev.amulai.in, both languages this branch ships:sm:px-6.npm run buildgreen; pre-commit eslint 0 errors (77 pre-existing warnings) +tsc -b.Deploy
oan-ui-chat-prod-ciCronWorkflow is suspended, so merging does not deploy. Needsrun-oan-ui-chat-build.shon the prod control plane after merge.🤖 Generated with Claude Code