fix: make GitHub releases work with the auto updater - #37
Draft
Jayian1890 wants to merge 2 commits into
Draft
Conversation
Ignore GitHub release checksum files, unwrap nested Actions artifact zips, and treat a PK zip payload as a successful download even when GitHub redirects the asset. Co-authored-by: jterrance00041622 <jterrance00041622@students.iticollege.edu>
Release CI now publishes only OpenNOW-<version>-macOS.zip, uses custom patch notes, and removes checksum sidecar assets that the auto-updater should not consume. Co-authored-by: jterrance00041622 <jterrance00041622@students.iticollege.edu>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.51 was published with an extra
OpenNOW-1.51-macOS.zip.sha256sidecar, and release CI only uploaded a GitHub Actions artifact wrapper (zip + checksum) instead of a GitHub Release the auto-updater can consume.The live v1.51 GitHub release is already repaired:
OpenNOW-1.51-macOS.zipremainsOpenNOW.appversion 1.51 / build 53 (SHA-256c9255adb…)This PR keeps future releases compatible:
OpenNOW-<version>-macOS.zip, unwraps nested Actions artifact zips, and accepts a PK zip payload after GitHub’s asset redirectDocs/GitHubReleaseNotes.mdand deletes leftover sidecar assetsTest notes
/releases/latestnow returns a singleOpenNOW-1.51-macOS.zipasset and custom notesOpenNOW.appwithCFBundleShortVersionString1.51and bundle idio.github.opencloudgaming.opennowSwift package tests were not run in this Linux environment (no Swift toolchain). macOS CI should run
OpenNOWGitHubUpdaterTests.