Skip to content

fix: make GitHub releases work with the auto updater - #37

Draft
Jayian1890 wants to merge 2 commits into
mainfrom
cursor/fix-github-release-updater-0d0e
Draft

fix: make GitHub releases work with the auto updater#37
Jayian1890 wants to merge 2 commits into
mainfrom
cursor/fix-github-release-updater-0d0e

Conversation

@Jayian1890

Copy link
Copy Markdown
Collaborator

Summary

v1.51 was published with an extra OpenNOW-1.51-macOS.zip.sha256 sidecar, and release CI only uploaded a GitHub Actions artifact wrapper (zip + checksum) instead of a GitHub Release the auto-updater can consume.

The live v1.51 GitHub release is already repaired:

  • Only OpenNOW-1.51-macOS.zip remains
  • Custom patch notes name that zip and no longer include the checksum sidecar
  • The zip still contains OpenNOW.app version 1.51 / build 53 (SHA-256 c9255adb…)

This PR keeps future releases compatible:

  • Updater ignores checksum/signature sidecars, prefers the versioned OpenNOW-<version>-macOS.zip, unwraps nested Actions artifact zips, and accepts a PK zip payload after GitHub’s asset redirect
  • Release CI publishes that zip with custom notes from Docs/GitHubReleaseNotes.md and deletes leftover sidecar assets

Test notes

  • Parser tests cover checksum-first asset lists, version-matching zip preference, nested Actions wrapper names, and zip magic bytes
  • Live /releases/latest now returns a single OpenNOW-1.51-macOS.zip asset and custom notes
  • Downloaded zip contains OpenNOW.app with CFBundleShortVersionString 1.51 and bundle id io.github.opencloudgaming.opennow

Swift package tests were not run in this Linux environment (no Swift toolchain). macOS CI should run OpenNOWGitHubUpdaterTests.

Open in Web Open in Cursor 

cursoragent and others added 2 commits August 20, 2026 11:14
Ignore GitHub release checksum files, unwrap nested Actions artifact zips, and treat a PK zip payload as a successful download even when GitHub redirects the asset.

Co-authored-by: jterrance00041622 <jterrance00041622@students.iticollege.edu>
Release CI now publishes only OpenNOW-<version>-macOS.zip, uses custom patch notes, and removes checksum sidecar assets that the auto-updater should not consume.

Co-authored-by: jterrance00041622 <jterrance00041622@students.iticollege.edu>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1efc6de1-a345-4d9b-acb3-9fa0b3907d91

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants