Skip to content

[PATCH v1] api: crypto: deprecate session output pool #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TuomasTaipale wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PATCH v1] api: crypto: deprecate session output pool #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/odp/api/spec/crypto_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,12 +942,13 @@

/** Output pool
*
* This field is unused and will be deprecated later.
* The value must be left to the default value.
*
* Default value is ODP_POOL_INVALID.
*
* @deprecated Unused by current operation types.
*/
odp_pool_t output_pool;
odp_pool_t ODP_DEPRECATE(output_pool);

Check failure on line 951 in include/odp/api/spec/crypto_types.h

View workflow job for this annotation

GitHub Actions / Checkpatch 

WARNING: function definition argument 'output_pool' should also have an identifier name

} odp_crypto_session_param_t;

Expand Down
2 changes: 2 additions & 0 deletions platform/linux-generic/odp_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ void _odp_crypto_session_print(const char *type, uint32_t index,
param->auth_aad_len);
len += _odp_snprint(&str[len], n - len, " compl_queue %" PRIu64 "\n",
odp_queue_to_u64(param->compl_queue));
#if ODP_DEPRECATED_API
len += _odp_snprint(&str[len], n - len, " output_pool %" PRIu64 "\n",
odp_pool_to_u64(param->output_pool));
#endif
_ODP_PRINT("%s\n", str);
}
1 change: 0 additions & 1 deletion platform/linux-generic/odp_ipsec_sad.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,6 @@ odp_ipsec_sa_t odp_ipsec_sa_create(const odp_ipsec_sa_param_t *param)

crypto_param.op_mode = ODP_CRYPTO_SYNC;
crypto_param.compl_queue = ODP_QUEUE_INVALID;
crypto_param.output_pool = ODP_POOL_INVALID;

crypto_param.cipher_alg = param->crypto.cipher_alg;
crypto_param.cipher_key = param->crypto.cipher_key;
Expand Down
2 changes: 2 additions & 0 deletions test/validation/api/crypto/odp_crypto_test_inp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ static void test_defaults(uint8_t fill)
CU_ASSERT(param.auth_alg == ODP_AUTH_ALG_NULL);
CU_ASSERT(param.auth_iv_len == 0);
CU_ASSERT(param.auth_aad_len == 0);
#if ODP_DEPRECATED_API
CU_ASSERT(param.output_pool == ODP_POOL_INVALID);
#endif
}

static void test_default_values(void)
Expand Down
Loading