Skip to content

Add Sony IMX662 sensor to build system #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegok3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Sony IMX662 sensor to build system #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d13d92
Add Sony IMX662 sensor to build system
diegok3 Aug 5, 2026
2850990
Add IMX662 patches and tools
Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion general/overlay/etc/init.d/S70vendor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ case "$1" in
start)
echo "Loading vendor modules..."
vendor=$(ipcinfo -v)
load_"$vendor" -i
load_"$vendor" -i -s imx662
;;

stop)
Expand Down
7 changes: 4 additions & 3 deletions general/package/hisilicon-opensdk/hisilicon-opensdk.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#
################################################################################

HISILICON_OPENSDK_SITE = $(call github,openipc,openhisilicon,$(HISILICON_OPENSDK_VERSION))
HISILICON_OPENSDK_VERSION = ff20187b
HISILICON_OPENSDK_SITE = $(call github,diegok3,openhisilicon,$(HISILICON_OPENSDK_VERSION))

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational

3. Source url inconsistency 🐞 Bug ⚙ Maintainability

The Kconfig help text still points to https://github.com/OpenIPC/openhisilicon while the package
now downloads from diegok3/openhisilicon, creating a provenance/documentation mismatch. This makes
it harder to determine the actual audited source for builds from the menuconfig help alone.
Agent Prompt 
### Issue description
The package download source repo changed to `diegok3/openhisilicon`, but the help text still references `OpenIPC/openhisilicon`.

### Issue Context
In Buildroot-style packages, `Config.in` help often serves as the human-facing pointer for where the source comes from.

### Fix Focus Areas
- general/package/hisilicon-opensdk/Config.in[6-9]
- general/package/hisilicon-opensdk/hisilicon-opensdk.mk[7-8]

### Suggested fix
Either:
- Update the help URL to the fork while this fork is authoritative for builds, or
- Keep the OpenIPC URL but add a note in the help text stating that builds currently fetch from `diegok3/openhisilicon@<sha>` (and why).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

HISILICON_OPENSDK_VERSION = 6c46247
Comment on lines +7 to +8

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Fork affects all configs 🐞 Bug ☼ Reliability

The PR switches HISILICON_OPENSDK_SITE/HISILICON_OPENSDK_VERSION globally, so every build that
selects hisilicon-opensdk (across multiple HiSilicon SoC families) will now consume
diegok3/openhisilicon@6c46247, not just hi3516cv6xx. This broadens the compatibility/provenance
risk well beyond the stated IMX662 addition.
Agent Prompt 
### Issue description
`hisilicon-opensdk` is used for multiple SoC families, but the PR changes the package download source globally to a third-party fork/commit to add IMX662 support.

### Issue Context
The makefile contains dependency wiring and install logic for many `OPENIPC_SOC_FAMILY` values, meaning the package is not specific to hi3516cv6xx.

### Fix Focus Areas
- general/package/hisilicon-opensdk/hisilicon-opensdk.mk[7-40]

### Suggested fix
- If only hi3516cv6xx needs the fork, make the site/version conditional on `OPENIPC_SOC_FAMILY` (use the fork for `hi3516cv6xx`, keep `openipc/openhisilicon` for others).
- Alternatively, mirror/cherry-pick the IMX662 change into the canonical upstream used by the project and keep the package pointing at that upstream.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational

2. Abbreviated commit pin 🐞 Bug ⚙ Maintainability

HISILICON_OPENSDK_VERSION is shortened to a 7-character SHA (6c46247), which is less robust for
long-term reproducibility than a full commit hash and is weaker than the prior 8-character pin. If
the abbreviation ever becomes ambiguous/unresolvable, the GitHub archive download will fail.
Agent Prompt 
### Issue description
The package version is pinned to a 7-character abbreviated commit hash.

### Issue Context
The download URL is derived from `$(call github,...)` using `HISILICON_OPENSDK_VERSION` as the archive ref.

### Fix Focus Areas
- general/package/hisilicon-opensdk/hisilicon-opensdk.mk[7-8]

### Suggested fix
Replace `HISILICON_OPENSDK_VERSION = 6c46247` with the full 40-character commit SHA (or a stable tag) to ensure unambiguous, reproducible fetches.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


HISILICON_OPENSDK_LICENSE = GPL-3.0
HISILICON_OPENSDK_LICENSE_FILES = LICENSE
Expand Down Expand Up @@ -233,7 +233,8 @@ HISILICON_OPENSDK_SENSORS_hi3516cv6xx = \
smart_sc431hai/libsns_sc431hai \
smart_sc4336p/libsns_sc4336p \
smart_sc450ai/libsns_sc450ai \
smart_sc500ai/libsns_sc500ai
smart_sc500ai/libsns_sc500ai \
sony_imx662/libsns_imx662
HISILICON_OPENSDK_SENSORS_hi3519dv500 = \
gst_412c/libsns_gst412c \
omnivision_os04a10/libsns_os04a10 \
Expand Down
4 changes: 2 additions & 2 deletions general/package/hisilicon-osdrv-hi3516cv6xx/files/script/load_hisilicon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# This is part of OpenIPC.org project | 2026.03.01
#

SNS_TYPE0=sc4336p;
SNS_TYPE0=imx662;
SNS_TYPE1=sc4336p;
SYS_PROFILE=0
IR_AUTO=0
Expand Down Expand Up @@ -213,7 +213,7 @@ load_usage()
echo " -ir_auto config ir_auto enable [default: 0]"
echo " -profile config sys_profile [default: 0]"
echo " -h help information"
echo -e "Available sensors:sc4336p gc4023 sc450ai sc500ai sc431hai os04d10 imx307 os02m10 bt1120/bt656/bt601"
echo -e "Available sensors:sc4336p gc4023 sc450ai sc500ai sc431hai os04d10 imx307 os02m10 imx662 bt1120/bt656/bt601"
echo -e "for example: $0 -i -sensor0 sc4336p -sensor1 sc4336p -mmz_start 0x42000000 -mmz_size 96M -ir_auto 1\n"
}

Expand Down
199 changes: 199 additions & 0 deletions tools/imx662/i2c_recovery.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,199 @@
#define _GNU_SOURCE
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/ioctl.h>
#include <sys/mman.h>
#include <sys/time.h>
#include <time.h>
#include <errno.h>
#include <stdint.h>
#include <linux/i2c.h>
#include <linux/i2c-dev.h>

#define IOCFG2_BASE 0x17940000
#define IOCFG2_SIZE 0x1000
#define GPIO6_BASE 0x11096000
#define GPIO6_SIZE 0x1000

/* I2C0 pin mux registers */
#define I2C0_SDA_REG (IOCFG2_BASE + 0x98)
#define I2C0_SCL_REG (IOCFG2_BASE + 0x9C)

/* IOCFG value for I2C function (func 5) */
#define IOCFG_I2C_FUNC 0x1135
/* IOCFG value for GPIO function (func 0) with pull-up */
#define IOCFG_GPIO_FUNC 0x1100

/* GPIO register offsets */
#define GPIO_DATA 0x3FC
#define GPIO_DIR 0x400
#define GPIO_SET 0x100
#define GPIO_CLR 0x140

static volatile uint32_t *map_reg(uint32_t phys_addr, size_t size)
{
int fd = open("/dev/mem", O_RDWR | O_SYNC);
if (fd < 0) {
fprintf(stderr, "open /dev/mem: %s\n", strerror(errno));
return NULL;
}
void *map = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, phys_addr);
close(fd);
if (map == MAP_FAILED) {
fprintf(stderr, "mmap 0x%x: %s\n", phys_addr, strerror(errno));
return NULL;
}
return (volatile uint32_t *)map;
}

static inline void reg_write(volatile uint32_t *base, uint32_t offset, uint32_t val)
{
*(base + offset / 4) = val;
}

static inline uint32_t reg_read(volatile uint32_t *base, uint32_t offset)
{
return *(base + offset / 4);
}

static inline void udelay(int us)
{
usleep(us);
}

static inline void mdelay(int ms)
{
usleep(ms * 1000);
}

static void gpio_set(volatile uint32_t *gpio, int pin, int val)
{
if (val)
reg_write(gpio, GPIO_SET, 1 << pin);
else
reg_write(gpio, GPIO_CLR, 1 << pin);
}

static void gpio_dir(volatile uint32_t *gpio, int pin, int output)
{
uint32_t dir = reg_read(gpio, GPIO_DIR);
if (output)
dir |= (1 << pin);
else
dir &= ~(1 << pin);
reg_write(gpio, GPIO_DIR, dir);
}

static int gpio_get(volatile uint32_t *gpio, int pin)
{
uint32_t data = reg_read(gpio, GPIO_DATA);
return (data >> pin) & 1;
}

int main(int argc, char *argv[])
{
fprintf(stderr, "=== I2C Bus Recovery (GPIO bit-bang) ===\n");

/* Map IOCFG2 for pin mux */
volatile uint32_t *iocfg2 = map_reg(IOCFG2_BASE, IOCFG2_SIZE);
if (!iocfg2) return 1;

/* Map GPIO6 for bit-bang */
volatile uint32_t *gpio6 = map_reg(GPIO6_BASE, GPIO6_SIZE);
if (!gpio6) return 1;

/* Step 1: Read current pin state */
uint32_t sda_val = reg_read(iocfg2, 0x98);
uint32_t scl_val = reg_read(iocfg2, 0x9C);
fprintf(stderr, "[1] Current I2C0 pin mux: SDA=0x%x, SCL=0x%x\n", sda_val, scl_val);

/* Step 2: Switch pins to GPIO (func 0) */
fprintf(stderr, "[2] Switching I2C0 pins to GPIO mode...\n");
reg_write(iocfg2, 0x98, IOCFG_GPIO_FUNC);
reg_write(iocfg2, 0x9C, IOCFG_GPIO_FUNC);
udelay(10);

/* Step 3: Configure SCL as output, SDA as input */
fprintf(stderr, "[3] Configuring GPIO6_6 (SDA) as input, GPIO6_7 (SCL) as output...\n");
gpio_dir(gpio6, 6, 0); /* SDA = input */
gpio_dir(gpio6, 7, 1); /* SCL = output */
udelay(10);

/* Step 4: Read SDA level */
int sda_level = gpio_get(gpio6, 6);
fprintf(stderr, "[4] SDA level before recovery: %d\n", sda_level);

/* Step 5: Generate 9 clock pulses on SCL to free SDA */
fprintf(stderr, "[5] Generating 9 clock pulses on SCL...\n");
for (int i = 0; i < 9; i++) {
gpio_set(gpio6, 7, 0);
udelay(5);
gpio_set(gpio6, 7, 1);
udelay(5);
sda_level = gpio_get(gpio6, 6);
fprintf(stderr, " Clock %d: SDA=%d\n", i + 1, sda_level);
if (sda_level == 1) {
fprintf(stderr, " SDA released after %d clocks!\n", i + 1);
break;
}
}

/* Step 6: Generate STOP condition (SDA low->high while SCL high) */
fprintf(stderr, "[6] Generating STOP condition...\n");
gpio_dir(gpio6, 6, 1); /* SDA as output */
gpio_set(gpio6, 6, 0); /* SDA low */
udelay(5);
gpio_set(gpio6, 7, 1); /* SCL high */
udelay(5);
gpio_set(gpio6, 6, 1); /* SDA high -> STOP */
udelay(5);

/* Step 7: Check SDA/SCL levels */
gpio_dir(gpio6, 6, 0); /* SDA back to input */
udelay(10);
sda_level = gpio_get(gpio6, 6);
int scl_level = gpio_get(gpio6, 7);
fprintf(stderr, "[7] After recovery: SDA=%d, SCL=%d\n", sda_level, scl_level);

/* Step 8: Restore I2C function */
fprintf(stderr, "[8] Restoring I2C0 pin mux...\n");
reg_write(iocfg2, 0x98, IOCFG_I2C_FUNC);
reg_write(iocfg2, 0x9C, IOCFG_I2C_FUNC);
mdelay(10);

/* Step 9: Try I2C read */
fprintf(stderr, "[9] Trying I2C read (chip ID 0x30DC)...\n");
int fd = open("/dev/i2c-0", O_RDWR);
if (fd < 0) {
fprintf(stderr, " open /dev/i2c-0: %s\n", strerror(errno));
} else {
/* I2C_SLAVE_FORCE with 7-bit address */
if (ioctl(fd, I2C_SLAVE_FORCE, 0x1A) < 0) {
fprintf(stderr, " I2C_SLAVE_FORCE: %s\n", strerror(errno));
} else {
/* Write reg address, then read back */
unsigned char buf[3];
buf[0] = 0x30;
buf[1] = 0xDC;
int ret = write(fd, buf, 2);
if (ret < 0) {
fprintf(stderr, " write reg addr: %s (errno=%d)\n", strerror(errno), errno);
} else {
memset(buf, 0, sizeof(buf));
ret = read(fd, buf, 1);
if (ret < 0) {
fprintf(stderr, " read data: %s (errno=%d)\n", strerror(errno), errno);
} else {
fprintf(stderr, " Chip ID: 0x%02x (expected 0x32)\n", buf[0]);
}
}
}
close(fd);
}

fprintf(stderr, "\n=== Done ===\n");
return 0;
}
Loading