Bbs panacea remastering

[thamstras]

As you can see from the commit dates I wrote this a little while ago, but I haven't been able to confirm that it works correctly with custom assets. I don't know when I'll have the time or the energy so I'm making this now so A) it doesn't get lost and B) hopefully inspire someone else to confirm it.

This updates the texture offset scanning code in Panacea to handle BBS' file types.

Of note:

• TM2 handling as been updated so the flags that KH2 uses are now passed in as a defaulted parameter, so BBS can reuse that code without getting the flag values which it doesn't use.
• BBS' arc texture ordering is as follows: Textures are ordered by their offset within the enclosing .arc file, except for .txa files, which immediately precede the textures of the .pmo/.pmp they're attached to, regardless of the .txa file's position within the .arc file.
• Based on testing I did with a separate test harness, this code does not correctly produce the offsets matching the remastering entries of every file in the game, but inspecting the failing results suggests that at least some of those remastering entries are bogus. The current code matches 98.7% of files with remastering entries.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8ade697-bb9b-42e3-883b-15c125dc4602

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud