feat: refocus the Analyzer screen on music, add frequency-scale and s… - #43
Merged
Merged
Conversation
…peed controls The Analyzer screen is for listening to music and instruments, so the voice-analysis displays it had borrowed from the Voice & Vowels screen no longer belong there: - spectrogram: drop the F0 and formant tracks - spectrum: drop the LPC envelope and the formant markers (the whole render path, since the Composer's only use of them was on synthesized partials) - readout: drop the voiced/unvoiced indicator, the F1-F4 table, HNR and CPP, leaving pitch, note + cents, and level - drop the standing-wave strip; StandingWaveNode moves to composer-screen/view, its only remaining user The harmonic overlays stay — harmonic markers, allowed-harmonic bands and mode numbers all describe amplitude vs. frequency — and with them the boundary-model selector that feeds the allowed-harmonic shading. New controls: - Frequency Scale (linear / logarithmic) for both the spectrogram's y axis and the spectrum's x axis. Charts plot a transformed coordinate (Hz, or log2 Hz) so bamboo's evenly spaced grid lands one line per octave, with ticks labelled back in Hz. ChartFrame.setXAxis()/setYAxis() retarget range, spacing and label format in place. - Scroll Speed (0.5x-4x): columns written per analyzed frame, carrying the fractional remainder so speeds below 1x write a column every few frames instead of rounding to a standstill. Fixes: freezing the display kept the audio playing. isFrozenProperty moves to BaseAnalysisModel, where it both halts step() and folds into isMonitoringProperty, so the sound stops with the picture — on the Composer screen too, which had the same bug. Also replaces ChartFrame's bamboo AxisLine (pinned to model value 0, which wanders off-chart and drags the node's bounds with it on any axis that excludes 0) with a line at the plotting area's left edge, and localizes the spectrogram's hardcoded y-axis title. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…peed controls
The Analyzer screen is for listening to music and instruments, so the voice-analysis displays it had borrowed from the Voice & Vowels screen no longer belong there:
The harmonic overlays stay — harmonic markers, allowed-harmonic bands and mode numbers all describe amplitude vs. frequency — and with them the boundary-model selector that feeds the allowed-harmonic shading.
New controls:
Fixes: freezing the display kept the audio playing. isFrozenProperty moves to BaseAnalysisModel, where it both halts step() and folds into isMonitoringProperty, so the sound stops with the picture — on the Composer screen too, which had the same bug.
Also replaces ChartFrame's bamboo AxisLine (pinned to model value 0, which wanders off-chart and drags the node's bounds with it on any axis that excludes 0) with a line at the plotting area's left edge, and localizes the spectrogram's hardcoded y-axis title.
Description
Type of change
Related issues
Fixes #
Related to #
Testing
npm run lintnpm run checknpm run buildnpm test(if applicable)How to test
Checklist