Validate model variable sizes before allocation - #2091
Merged
jordimas merged 5 commits intoAug 30, 2026
Conversation
jordimas
force-pushed
the
security/model-bin-loader-validation
branch
from
August 29, 2026 16:46
92107fd to
55d4138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTranslate2 trusted model.bin tensor metadata before validation, allowing crafted models to trigger load-time crashes or out-of-bounds reads. This validates dimensions and payload sizes before allocation.
Thanks to Hyeonbell hy3onb3ll@gmail.com for responsibly reporting this issue.