Check for overflow in StorageView::reserve byte size - #2092
Closed
jordimas wants to merge 1 commit into
Closed
Conversation
jordimas
force-pushed
the
security/storage-view-overflow-check
branch
from
August 30, 2026 12:06
307ae33 to
c8240ba
Compare
infinityscroll
approved these changes
Aug 30, 2026
Collaborator
Author
|
We will integrate #2094 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject negative sizes and detect dim_t overflow when computing the allocation byte count in StorageView::reserve, preventing a malformed model from producing an undersized buffer. Adds regression tests.
Reported by Jitendra Prajapati (Infinityscroll).