Skip to content

remove runtime dependency on setuptools - #2096

Merged
jordimas merged 1 commit into
OpenNMT:masterfrom
Ravencentric:remove-setuptools
Aug 31, 2026
Merged

remove runtime dependency on setuptools#2096
jordimas merged 1 commit into
OpenNMT:masterfrom
Ravencentric:remove-setuptools

Conversation

@Ravencentric

@Ravencentric Ravencentric commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

I skimmed the repo and could not find setuptools actually being used at runtime yet users get setuptools when they install ctranslate2. Note that you don't need a runtime dependency on setuptools to build a package with setuptools, pyproject.toml already includes setuptools as a build time dependency

"ctranslate2" | uv pip compile -
Resolved 4 packages in 5ms
# This file was autogenerated by uv via the following command:
#    uv pip compile -
ctranslate2==4.8.1
numpy==2.5.2
    # via ctranslate2
pyyaml==6.0.3
    # via ctranslate2
setuptools==84.0.0
    # via ctranslate2

@jordimas

Copy link
Copy Markdown
Collaborator

Good catch, thanks!"

@jordimas
jordimas merged commit f842545 into OpenNMT:master Aug 31, 2026
22 checks passed
@Ravencentric
Ravencentric deleted the remove-setuptools branch August 31, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants