fix: stabilize useEffect dependency in CodeDashboard - #105
Open
ivangarm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
CodeDashboardhas auseEffectwith an empty dependency array that referencesloadSessions, butloadSessionsis not wrapped inuseCallback. This means:loadSessionsis recreated on every render, but the effect captures only the initial version (stale closure).react-hooks/exhaustive-depsrule would flag this as a missing dependency.The fix wraps
loadSessionsinuseCallbackwith an empty dependency array (it only references stable state setters), and addsloadSessionsto theuseEffectdependency array. This makes the hook lint-clean and ensures the interval always calls the latest version of the function.Changes:
useCallbackto the React importloadSessionsinuseCallback(async () => { ... }, [])useEffectdependency from[]to[loadSessions]Verified by reviewing the diff and confirming that
setIsLoading,setError, andsetSessionsare all stable state setters fromuseState, so the empty dependency array onuseCallbackis correct.