fix: use context manager for file read in pdf_renderer.py - #106
Open
loganbail wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I found
The
_requires_xelatexhelper inbackend/app/services/pdf_renderer.py(line 55) opens a.texfile and reads the first 4096 bytes without a context manager:The file handle is never explicitly closed. In CPython with refcounting GC it gets collected quickly, but under PyPy or if
read()itself raises, the handle leaks. This is especially relevant because_requires_xelatexis called insidecompile_latex_project— during a LaTeX compilation run, multiple files could be probed.The fix
Wrapped the read in a
withstatement so the file handle is deterministically closed:The existing
encoding="utf-8"anderrors="ignore"parameters are preserved — the only change is ensuring deterministic file handle cleanup.Testing
Added
tests/test_pr_07_pdf_renderer_file.pywith five tests:test_requires_xelatex_with_ctexartTrueforctexartdocument classtest_requires_xelatex_with_standard_latexFalsefor standardarticleclasstest_requires_xelatex_with_fontspecTruewhenfontspecpackage is usedtest_requires_xelatex_missing_fileFalsefor nonexistent files (no crash)test_no_unclosed_file_readsopen(...).read(...)patterns remainAll five pass.