fix: use span instead of div for Badge - #89
Open
juliag106 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Badge component renders a div element, which is block-level by default. Badges in this codebase are styled with inline-flex and used inline with text or inside flex containers. Using a block-level element for an inline UI piece is semantically incorrect and can cause subtle layout issues when badges appear mid-paragraph.
Changes
In frontend/src/components/ui/badge.tsx:
Notes
The inline-flex class on the badge variants already compensates for display behavior, so visual rendering is unchanged. The fix is purely about using the semantically correct HTML element. No callers pass block-specific props that would break.
Verified by reviewing all Badge usage across the frontend. All call sites pass standard HTML attributes (className, children, onClick) that are common to both div and span.