fix: validate edge endpoints exist in graph_builder.py dependency_map - #94
Open
ivyw960 wants to merge 1 commit into
Open
fix: validate edge endpoints exist in graph_builder.py dependency_map#94ivyw960 wants to merge 1 commit into
ivyw960 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphBuilder.dependency_map()usesdict.setdefaultto register edge endpoints, which silently creates phantom entries when an edge references a node ID that does not exist in the blueprint workflow. Later,refresh_step_statusestries to look up these phantom parents instep_indexand crashes with an uninformativeKeyError.Changes in
backend/app/faros/runtime/graph_builder.py:node_idsset from the workflow before iterating edgessourceandtargetexist in the node setValueErrorwith the offending edge details and node ID(s)setdefaultcalls since we now validate before appendingAdded
backend/tests/test_pr_12_graph_builder_edges.py(5 tests): valid edges produce correct upstream/downstream lists, edges with missing source/target/both raiseValueError, and a no-edge blueprint works cleanly. All tests pass.