Skip to content

fix: gate SSL verification bypass on env flag in search_service.py #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isla-brooks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gate SSL verification bypass on env flag in search_service.py #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions backend/app/services/search_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def search(self, query: str, limit: int = 10, categories: Optional[List[str]] =
last_error = e
if (
url.startswith("https://")
and _env_bool("FAROS_ALLOW_INSECURE_ARXIV_SSL", True)
and _env_bool("FAROS_ALLOW_INSECURE_SSL", False)
and "CERTIFICATE_VERIFY_FAILED" in str(e)
):
try:
Expand Down Expand Up @@ -1088,8 +1088,11 @@ def search(self, query: str, limit: int = 10) -> List[SearchResult]:
with _urlopen(request, timeout=30) as resp:
raw = resp.read().decode("utf-8")
except urllib.error.URLError as e:
if "CERTIFICATE" in str(e) or "SSL" in str(e):
logger.info("DBLP: SSL cert untrusted, retrying with unverified context")
if ("CERTIFICATE" in str(e) or "SSL" in str(e)) and _env_bool("FAROS_ALLOW_INSECURE_SSL", False):
logger.warning(
"DBLP: SSL cert untrusted, retrying with unverified context. "
"Set FAROS_ALLOW_INSECURE_SSL=false to disable this fallback."
)
with _urlopen(request, timeout=30, context=_INSECURE_SSL_CONTEXT) as resp:
raw = resp.read().decode("utf-8")
else:
Expand Down