fix: add encoding="utf-8" to paper_storage.py meta.json reads - #99
Open
cmacd89 wants to merge 1 commit into
Open
fix: add encoding="utf-8" to paper_storage.py meta.json reads#99cmacd89 wants to merge 1 commit into
cmacd89 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most
open()calls inpaper_storage.pyalready specifyencoding="utf-8"(lines 356, 372, 424), but two read paths --get_paperat line 100 andlist_papersat line 112 -- were missing it. This means they fall back to the platform default encoding, which can corrupt or reject non-ASCII paper titles and author names on non-UTF-8 systems.This PR adds
encoding="utf-8"to those two calls, bringing them in line with the rest of the file.What changed:
backend/app/storage/paper_storage.py: 2 lines changed (lines 100, 112)backend/tests/test_pr_03_paper_storage_encoding.py: round-trip tests with Chinese and accented textHow verified: Both tests pass in the sandbox container (2/2 passed).