breaking: Specification fixes - #149
Open
CZDanol wants to merge 7 commits into
Open
Conversation
To match architecture changes. Still a partial change - the key and material_types_enum.yaml are left untouched to prevent issues in dependencies.
Change the units from mm to um to match the architecture. This mismatch was silent and resulted in a bunch of data being written wrong to the tags. To remedy this, drop the original keys from the spec completely, and introduce new keys. Also add _v2 suffix to the fields to indicate that the field data format has been changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.