Skip to content

wip: Support 'reload' action for supervise-daemon - #1091

Open
meoovv wants to merge 6 commits into
OpenRC:masterfrom
meoovv:s-d-reload
Open

meoovv wants to merge 6 commits into
OpenRC:masterfrom
meoovv:s-d-reload

Conversation

@meoovv

@meoovv meoovv commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

closes #1090
Not yet adding behavior described in #1090 (comment) , though

@meoovv

meoovv commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

support for option that permits or disallows reloads and option that specifies the reload signal could be added in sync with #1052

@meoovv

meoovv commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

both #1032 and #1052 use name reloadsig for the reload-signal option and provide no boolean option for enabling or disabling reloads. so to mark a service as non-reloadable, user needs to set reloadsig="".

Comment thread man/openrc-run.8
Comment on lines +55 to +56
Sends reload (SIGHUP) signal to the service, only supported when supervisor is supervise-daemon
or s6. Note that this may kill daemons which do not process SIGHUP, supervise-daemon will restart them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start-stop-daemon also has --signal, so there's no reason it couldn't also implement reload()

while we do want to move towards defaulting to supervise-daemon, plenty of services ship a reload function for s-s-d, so having a way for those services to drop their custom functions would help with that goal

this leaves only runit, which does support sending a signal but honestly i have no idea how is our state of support for runit at this point that maybe we leave it missing for now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, theres some activity around adding reload support to s-s-d in #1032, but author doesnt seem to be addressing concerns. i could create a similar pr for s-s-d, then we could wait for author of #1052 and once everything has been merged, list reload in openrc-run.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f_ is very much active on the openrc irc channel and ska is also around there. i mostly asked both of them to wait with this features until 0.64 was out (plus some time on top to chase regressions), there were too many features stacked on master

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, its probably time to call them back now 🧐

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meoovv I appreciate you're enthusiastic, but you're being rather pushy. Please try to dial it back.

@meoovv meoovv Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesamesam no one is asking to get everything done "by tomorrow evening", please dont misunderstand me! discussions should be focused and task-oriented, so that anyone can immediately see what needs to be done and get started. thats probably the key to productive teamwork !

@thesamesam thesamesam Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meoovv Yes, but projects don't generally need someone to come in and start delegating tasks. People work on FOSS projects when they feel like it. You don't need to tell navi to ping them, she can do that herself if or when she wants to.

But also, 0.64 and 0.64.1 only just came out. It's not like it's been ages.

discussions should be focused and task-oriented

It's not the same as running a meeting in a company.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree, but i can clarify things more gently if people do feel uncomfortable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking you to not try direct people.

Comment thread sh/supervise-daemon.sh
# except according to the terms contained in the LICENSE file.

extra_commands="healthcheck unhealthy ${extra_commands}"
extra_commands="healthcheck unhealthy reload ${extra_commands}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's becoming a default, might as well add to openrc-run directly like start and stop

@meoovv meoovv changed the title Support 'reload' action for supervise-daemon wip: Support 'reload' action for supervise-daemon Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reload support for supervise-daemon

3 participants