Conversation
|
support for option that permits or disallows reloads and option that specifies the reload signal could be added in sync with #1052 |
| Sends reload (SIGHUP) signal to the service, only supported when supervisor is supervise-daemon | ||
| or s6. Note that this may kill daemons which do not process SIGHUP, supervise-daemon will restart them. |
There was a problem hiding this comment.
start-stop-daemon also has --signal, so there's no reason it couldn't also implement reload()
while we do want to move towards defaulting to supervise-daemon, plenty of services ship a reload function for s-s-d, so having a way for those services to drop their custom functions would help with that goal
this leaves only runit, which does support sending a signal but honestly i have no idea how is our state of support for runit at this point that maybe we leave it missing for now
There was a problem hiding this comment.
There was a problem hiding this comment.
f_ is very much active on the openrc irc channel and ska is also around there. i mostly asked both of them to wait with this features until 0.64 was out (plus some time on top to chase regressions), there were too many features stacked on master
There was a problem hiding this comment.
so, its probably time to call them back now 🧐
There was a problem hiding this comment.
@meoovv I appreciate you're enthusiastic, but you're being rather pushy. Please try to dial it back.
There was a problem hiding this comment.
@thesamesam no one is asking to get everything done "by tomorrow evening", please dont misunderstand me! discussions should be focused and task-oriented, so that anyone can immediately see what needs to be done and get started. thats probably the key to productive teamwork !
There was a problem hiding this comment.
@meoovv Yes, but projects don't generally need someone to come in and start delegating tasks. People work on FOSS projects when they feel like it. You don't need to tell navi to ping them, she can do that herself if or when she wants to.
But also, 0.64 and 0.64.1 only just came out. It's not like it's been ages.
discussions should be focused and task-oriented
It's not the same as running a meeting in a company.
There was a problem hiding this comment.
disagree, but i can clarify things more gently if people do feel uncomfortable.
There was a problem hiding this comment.
I'm asking you to not try direct people.
| # except according to the terms contained in the LICENSE file. | ||
|
|
||
| extra_commands="healthcheck unhealthy ${extra_commands}" | ||
| extra_commands="healthcheck unhealthy reload ${extra_commands}" |
There was a problem hiding this comment.
if it's becoming a default, might as well add to openrc-run directly like start and stop
closes #1090
Not yet adding behavior described in #1090 (comment) , though