Conversation
navi-desu
reviewed
Sep 28, 2026
| { | ||
| local root_opts=",$(fstabinfo -o /)," | ||
| case "$root_opts" in | ||
| case ",${root_opts}," in |
Member
There was a problem hiding this comment.
unnecessary, root_opts already inserts commas in the string
Member
|
this just adds an extra pair of commas around the mount options, i don't think it fixes #907 at all, i'll have to take a look at it later |
meoovv
changed the title
Contributor
Author
|
yeah, i should've tested this first 🧐 |
Contributor
Author
|
fix would involve filtering out openrc/src/fstabinfo/fstabinfo.c Line 114 in aec5ded ill close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #907 , fix is similar to #1095