Add Tormented Demons - #213
Merged
Merged
Conversation
a-thoren
commented
Sep 5, 2026
a-thoren
commented
Contributor
- Added support for body customisations, only model for now
- Fixed an existing with checkNotCombat/checkNotCombatSelf in HuntCodec (I legitimately could've sworn that I had tested this before)
- Adjusted CombatNpcAttributeCollector to take an Npc since we need attributes at runtime
Mark7625
reviewed
Sep 5, 2026
Comment on lines
4
to
247
| @@ -25,12 +25,12 @@ import org.rsmod.game.client.Client | |||
| import org.rsmod.game.client.ClientCycle | |||
| import org.rsmod.game.client.NoopClient | |||
| import org.rsmod.game.client.NoopClientCycle | |||
| import org.rsmod.game.damage.DamageContributions | |||
| import org.rsmod.game.entity.player.Appearance | |||
| import org.rsmod.game.entity.player.PlayerUid | |||
| import org.rsmod.game.entity.player.PublicMessage | |||
| import org.rsmod.game.entity.util.EntityFaceAngle | |||
| import org.rsmod.game.entity.util.PathingEntityCommon | |||
| import org.rsmod.game.damage.DamageContributions | |||
| import org.rsmod.game.headbar.Headbar | |||
| import org.rsmod.game.hero.HeroPoints | |||
| import org.rsmod.game.hit.Hitmark | |||
| @@ -241,6 +241,7 @@ public class Player( | |||
| public var loggingOut: Boolean = false | |||
| public var pendingCloseClient: Boolean = false | |||
| public var closeClient: Boolean = false | |||
|
|
|||
| /** This flag should only be set when the game server is in the process of shutting down. */ | |||
| public var pendingShutdown: Boolean = false | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
What's with this random change
Contributor
Author
There was a problem hiding this comment.
I edited a file in that module so ran spotlessApply on the module and figured I'd leave the change in, if you want ill revert it
| infoProtocol.toggleOps(OpVisibility.showAll()) | ||
| } | ||
|
|
||
| /** Shows an overhead prayer/status icon (e.g. protection prayers) in the given [slot]. */ |
Collaborator
There was a problem hiding this comment.
I think this is over commenting tbh ?
| infoProtocol.setHeadIcon(slot, graphic, index) | ||
| } | ||
|
|
||
| /** Clears the overhead icon shown in [slot]. */ |
Collaborator
There was a problem hiding this comment.
I think this is over commenting tbh ?
| var entry: String? = null | ||
| var exit: String? = null | ||
|
|
||
| /** Per-phase attack-rate default; see [PhaseSpec.attackRate]. */ |
Collaborator
There was a problem hiding this comment.
I think this is over commenting tbh ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.