Skip to content

Add controller for torque controlled winches - #32

Merged
ufechner7 merged 12 commits into
mainfrom
merge_controllers
Aug 16, 2026
Merged

Add controller for torque controlled winches#32
ufechner7 merged 12 commits into
mainfrom
merge_controllers

Conversation

@ufechner7

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges the torque-output winch controller family into WinchControllers.jl, consolidating both speed/force (speed-command) and torque-command control modes into a single package with shared configuration (WCSettings) and documentation.

Changes:

  • Adds torque controllers (WinchPosController, WinchForceController) plus helper functions, and exports them from the main module.
  • Extends WCSettings and data/wc_settings.yaml with new tuning parameters for the torque controllers.
  • Adds the DiscretePIDs dependency and updates docs/README/changelog to reflect the new functionality.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/WinchControllers.jl Imports DiscretePIDs, exports the new torque-controller API, and includes torque_controllers.jl.
src/wc_settings.jl Expands WCSettings to cover torque-controller tuning and adjusts dt behavior/documentation.
src/torque_controllers.jl Introduces plant-agnostic torque controller implementations and supporting helpers.
README.md Moves torque-controlled winches from “Planned” to “Implemented” and links to the new docs.
Project.toml Bumps version to 0.6.0 and adds DiscretePIDs dependency + compat.
examples/test_reelout.jl Minor rename (calc_forceforce_law) to avoid ambiguity.
docs/src/winchcontroller.md Documents the new torque controller API via @docs.
data/wc_settings.yaml Adds YAML fields for torque-controller settings.
CHANGELOG.md Adds v0.6.0 entry describing the merged controllers and related changes.
.gitignore Ignores build/.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/wc_settings.jl Outdated
Comment thread src/wc_settings.jl Outdated
Comment thread src/torque_controllers.jl
Comment thread data/wc_settings.yaml
Comment thread src/torque_controllers.jl
@ufechner7 ufechner7 self-assigned this Aug 16, 2026
@ufechner7 ufechner7 changed the title Merge controllers Add controller for torque controlled winches Aug 16, 2026
@ufechner7
ufechner7 marked this pull request as ready for review August 16, 2026 12:53
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ufechner7
ufechner7 merged commit d0a0f52 into main Aug 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants