Add controller for torque controlled winches - #32
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR merges the torque-output winch controller family into WinchControllers.jl, consolidating both speed/force (speed-command) and torque-command control modes into a single package with shared configuration (WCSettings) and documentation.
Changes:
- Adds torque controllers (
WinchPosController,WinchForceController) plus helper functions, and exports them from the main module. - Extends
WCSettingsanddata/wc_settings.yamlwith new tuning parameters for the torque controllers. - Adds the
DiscretePIDsdependency and updates docs/README/changelog to reflect the new functionality.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WinchControllers.jl | Imports DiscretePIDs, exports the new torque-controller API, and includes torque_controllers.jl. |
| src/wc_settings.jl | Expands WCSettings to cover torque-controller tuning and adjusts dt behavior/documentation. |
| src/torque_controllers.jl | Introduces plant-agnostic torque controller implementations and supporting helpers. |
| README.md | Moves torque-controlled winches from “Planned” to “Implemented” and links to the new docs. |
| Project.toml | Bumps version to 0.6.0 and adds DiscretePIDs dependency + compat. |
| examples/test_reelout.jl | Minor rename (calc_force → force_law) to avoid ambiguity. |
| docs/src/winchcontroller.md | Documents the new torque controller API via @docs. |
| data/wc_settings.yaml | Adds YAML fields for torque-controller settings. |
| CHANGELOG.md | Adds v0.6.0 entry describing the merged controllers and related changes. |
| .gitignore | Ignores build/. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ufechner7
marked this pull request as ready for review
August 16, 2026 12:53
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.