Feature/assettree types - #61
Open
engbergandreas wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The regenerated outputs include multiple garbled/truncated docstrings and a README command that likely won’t forward script arguments correctly without --.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refreshes the generated TypeScript type surface for OpenSpace topics and the Lua library, adding the new assetTree topic types and updating related generated documentation and generator scripts.
Changes:
- Add generated
AssetTreeTopictypes and include them in the generated topic index/union. - Regenerate/update Lua library typings (
openspacelualibrary.ts) and supporting generator output types. - Update generation documentation and generator banner comment text used across generated topic files.
File summaries
| File | Description |
|---|---|
| src/types/generated/versiontopic.ts | Updates generator banner comment text. |
| src/types/generated/triggerpropertytopic.ts | Updates generator banner comment text. |
| src/types/generated/timetopic.ts | Updates generator banner comment text. |
| src/types/generated/subscriptiontopic.ts | Updates generator banner comment text. |
| src/types/generated/skybrowsertopic.ts | Updates generator banner comment text. |
| src/types/generated/setpropertytopic.ts | Updates generator banner comment text. |
| src/types/generated/sessionrecordingtopic.ts | Updates generator banner comment text. |
| src/types/generated/propertytreetopic.ts | Updates generator banner comment text. |
| src/types/generated/properties.ts | Updates generator banner comment text. |
| src/types/generated/profiletopic.ts | Updates generator banner comment text. |
| src/types/generated/openspacelualibrary.ts | Regenerated Lua library typings and doc comments (incl. new libs/types and formatting changes). |
| src/types/generated/missiontopic.ts | Updates generator banner comment text. |
| src/types/generated/luascripttopic.ts | Updates generator banner comment text. |
| src/types/generated/index.ts | Exports/imports assettreetopic and extends AllTopics union. |
| src/types/generated/getpropertytopic.ts | Updates generator banner comment text. |
| src/types/generated/flightcontrollertopic.ts | Updates generator banner comment text. |
| src/types/generated/eventtopic.ts | Updates event type surface (e.g., ParallelConnection → AstrocastConnection). |
| src/types/generated/errorlogtopic.ts | Updates generator banner comment text. |
| src/types/generated/enginemodetopic.ts | Updates generator banner comment text. |
| src/types/generated/downloadeventtopic.ts | Updates generator banner comment text. |
| src/types/generated/documentationtopic.ts | Updates generator banner comment text. |
| src/types/generated/cameratopic.ts | Updates generator banner comment text. |
| src/types/generated/camerapathtopic.ts | Updates generator banner comment text. |
| src/types/generated/authorizationtopic.ts | Updates generator banner comment text. |
| src/types/generated/assettreetopic.ts | Adds new generated assetTree topic schema typings. |
| src/types/generated/actionkeybindtopic.ts | Extends Action type with optional isHidden. |
| script/generatetypescriptfile.py | Extends custom type aliases used in Lua library generation. |
| script/generatetopictypes.mjs | Updates the standard generated-file banner text. |
| README.md | Updates the docs for running type generators. |
Review details
- Files reviewed: 3/29 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e/openspace-api-js into feature/assettree-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the assettreetopic types, and also updates the general types.