Force chunked transfer encoding to work around net-http bug - #90
Merged
Conversation
Contributor
|
oh nice! |
Member
Author
|
I made a test openvox-server build with this change and verified it fixes the issue. |
In ring-core 1.15.x, strings are written directly to the underlying stream and the stream is closed without flushing, which lets Jetty use Content-Length framing. With TLS 1.3, a NewSessionTicket may be sent immediately after the response data. Ruby's net-http sees the pending TLS record and blocks on a keep-alive check until timeout. Chunked encoding avoids this because the ticket is consumed during body reading rather than lingering in the TCP buffer. See OpenVoxProject/openvox-server#197 for more details. A fix in net-http is ruby/ruby#6423 but even if that gets merged into the version of Ruby we use in OpenVox, older agents will be vulnerable to this issue. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
austb
approved these changes
May 13, 2026
austb
left a comment
austb
left a comment
Contributor
There was a problem hiding this comment.
🦆 :insert-missing-tape-emoji-here:
PR looks fine, one comment on the comment possibly
nmburgan
force-pushed
the
fix-tls13-newsessionticket-hang
branch
from
May 13, 2026 21:58
6d752f3 to
cc70af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ring-core 1.15.x, strings are written directly to the underlying stream and the stream is closed without flushing, which lets Jetty use Content-Length framing. With TLS 1.3, a NewSessionTicket may be sent immediately after the response data. Ruby's net-http sees the pending TLS record and blocks on a keep-alive check until timeout. Chunked encoding avoids this because the ticket is consumed during body reading rather than lingering in the TCP buffer.
See OpenVoxProject/openvox-server#197 for more details.
A fix in net-http is ruby/ruby#6423 but even if that gets merged into the version of Ruby we use in OpenVox, older agents will be vulnerable to this issue.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent