4.6.3 - #1019
Conversation
add figure position
feat: callScene supports args
# Conflicts: # packages/webgal/src/Core/controller/stage/pixi/PixiController.ts # packages/webgal/src/Core/controller/stage/pixi/syncPixiStageState.ts # packages/webgal/src/Core/gameScripts/changeFigure.ts
…-settling fix: 修复 changeFigure -next 后 setTransform 继承 transform 错误
Deploying webgal-dev with
|
| Latest commit: |
1bf00ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22783be7.webgal-dev.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bf00ae720
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
| if (entry.writeReturnTo) { | ||
| setGameVar({ key: entry.writeReturnTo, value: returnValue }); |
There was a problem hiding this comment.
When a nested caller already has a local variable named by -writeReturnTo, this writes the result into the stage scope even though popFrame() has just restored the caller's locals. Since getValueFromState() prioritizes locals over stage variables, the unchanged local value permanently shadows the returned result, so a typical nested call such as returning into one of its input/local variables appears to lose the result. Write to the restored caller frame, or provide an explicit destination scope.
Useful? React with 👍 / 👎.
| }); | ||
| WebGAL.sceneManager.sceneData.currentSentenceId = loadFile.sceneData.currentSentenceId; | ||
| WebGAL.sceneManager.sceneData.sceneStack = cloneDeep(loadFile.sceneData.sceneStack); | ||
| WebGAL.sceneManager.sceneData.currentLocals = cloneDeep(loadFile.sceneData.currentLocals ?? {}); // 旧存档没有此字段 |
There was a problem hiding this comment.
When a flowchart node is unlocked while executing a callScene frame, FlowchartManager.createSnapshot() does not include sceneData.currentLocals; loading that node therefore takes this fallback and replaces all scene arguments and setVar -local values with {}. Subsequent expressions in the restored called scene can produce different results, even though ordinary saves and backlog snapshots now preserve these locals. Include currentLocals in flowchart snapshots rather than treating every such snapshot as a legacy save.
Useful? React with 👍 / 👎.
2 participants
No description provided.