DATA-4392: Fix Aasimar Scion of Humanity feat prerequisites - #7722
Closed
cpstence wants to merge 0 commit into
Closed
DATA-4392: Fix Aasimar Scion of Humanity feat prerequisites#7722cpstence wants to merge 0 commit into
cpstence wants to merge 0 commit into
Conversation
cpstence
force-pushed
the
DATA-4392-aasimar-humanity
branch
from
August 31, 2026 19:51
adb9ac4 to
865c4b8
Compare
Contributor
|
@cpstence your fix broke the test. Please verify it. |
Vest
marked this pull request as draft
September 1, 2026 08:35
Vest
marked this pull request as ready for review
September 1, 2026 08:47
cpstence
force-pushed
the
DATA-4392-aasimar-humanity
branch
from
September 1, 2026 14:53
3f31eed to
a9bbc17
Compare
Contributor
Author
|
The XSLT modifications from my other ticket accidentally hitched a ride onto this PR. I’ve just force-pushed a clean update to this branch. It removes the XSLT files entirely, removes the illegal RACESUBTYPE token that was breaking the test, and broadens the prerequisites in arg_feats.lst instead. The datatest is passing locally and this PR is now 100% isolated to just the Aasimar fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Jira Ticket: DATA-4392
Issue:
Aasimars with the "Scion of Humanity" alternate racial trait were not qualifying for human-specific feats (such as Defiant Luck), despite the trait explicitly stating they count as human for feat prerequisites.
Fix:
Appended the
RACESUBTYPE:Humantag to theScion of Humanityentry inarg_abilities_race.lst. This ensures the PCGen engine properly flags the character with the human subtype, satisfying thePRErequirements for human-only feats and effects.