Skip to content

CODE-253: Set default PDF export canvas dimensions to standard US Let… #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpstence wants to merge 2 commits into
base: master
Choose a base branch
from
+87 −73
Open

CODE-253: Set default PDF export canvas dimensions to standard US Let… #7728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a04bda
CODE-253: Set default PDF export canvas dimensions to standard US Let…
cpstence Sep 2, 2026
ae370ae
CODE-2537: Correct internal paper size identifier to resolve FTL expo…
cpstence Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions code/src/java/pcgen/core/Globals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,15 +742,29 @@ public static boolean selectPaper(final String paperName)
/**
* Apply the user's preferences to the initial state of the Globals.
*/
public static void initPreferences()
public static void initPreferences()
{
if (selectedPaper != -1)
{
// Already initialized
return;
}
final String papersize = PCGenSettings.getInstance().initProperty(PCGenSettings.PAPERSIZE, "A4");
selectPaper(papersize);

String defaultPaper = "A4";
String country = java.util.Locale.getDefault().getCountry();
if ("US".equalsIgnoreCase(country) || "CA".equalsIgnoreCase(country))
{
defaultPaper = "Letter";
}

String papersize = PCGenSettings.getInstance().initProperty(PCGenSettings.PAPERSIZE, defaultPaper);

// Self-healing fallback: If the saved paper size is invalid, force it to the regional default
if (!selectPaper(papersize))
{
PCGenSettings.getInstance().setProperty(PCGenSettings.PAPERSIZE, defaultPaper);
selectPaper(defaultPaper);
}
}

/**
Expand Down Expand Up @@ -1085,4 +1099,4 @@ public static LoadContext getContext()
{
return SettingsHandler.getGameAsProperty().get().getContext();
}
}
}
4 changes: 2 additions & 2 deletions outputsheets/d20/4e/pdf/fantasy_master_common_blocks.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/4e/pdf/inc_pagedimensions.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -44,7 +44,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_alt_largetext.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -57,7 +57,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_common_blocks.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_common_companion_box.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_no_header.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_no_spells.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -77,7 +77,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/fantasy_master_spell_list_only.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -65,7 +65,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/5e/pdf/inc_pagedimensions.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -44,7 +44,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/fantasy_master_alt_largetext.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -57,7 +57,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/fantasy_master_common_blocks.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -87,7 +87,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/fantasy_master_common_companion_box.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/fantasy_master_no_header.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/fantasy_master_spell_list_only.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy/pdf/inc_pagedimensions.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -44,7 +44,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/fantasy_craft/pdf/fantasy_master_common_blocks.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -87,7 +87,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/modern/pdf/csheet_modern_std.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/pathfinder_2/pdf/fantasy_master_alt_largetext.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -57,7 +57,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/pathfinder_2/pdf/fantasy_master_common_blocks.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -86,7 +86,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
4 changes: 2 additions & 2 deletions outputsheets/d20/pathfinder_2/pdf/fantasy_master_common_companion_box.xslt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<xsl:value-of select="25.4 * 11.0"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="297"/>
<xsl:value-of select="25.4 * 11.0"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand All @@ -78,7 +78,7 @@
<xsl:value-of select="25.4 * 8.5"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="210"/>
<xsl:value-of select="25.4 * 8.5"/>
</xsl:otherwise>
</xsl:choose>
</xsl:otherwise>
Expand Down
Loading
Loading