Fix compilation of patterns incorporating ECLASS and lookbehinds - #961
Merged
Conversation
carenas
reviewed
Aug 23, 2026
carenas
left a comment
Contributor
There was a problem hiding this comment.
I had the following tests instead in my version, which are IMHO more realistic and cover also the perl class syntax:
diff --git a/testdata/testinput1 b/testdata/testinput1
index 64b697f3..91e2c7a1 100644
--- a/testdata/testinput1
+++ b/testdata/testinput1
@@ -7154,6 +7154,13 @@ $/x
\= Expect no match
z
+/(?[\d-[1]]).(?<!x)/
+ 0a
+ 90
+\= Expect no match
+ 1a
+ 0x
+
/^.{4}/s
abcdef
abcde
diff --git a/testdata/testinput2 b/testdata/testinput2
index a7c1c846..c205e68e 100644
--- a/testdata/testinput2
+++ b/testdata/testinput2
@@ -7407,6 +7407,13 @@ a)"xI
/[^[[^]~~[^]]]/B,alt_extended_class,allow_empty_class
a
+/[\d--1].(?<!x)/alt_extended_class
+ 0a
+ 90
+\= Expect no match
+ 1a
+ 0x
+
# --------------
NWilson
force-pushed
the
user/niwilson/fix-lookbehind-eclass
branch
from
August 23, 2026 19:42
7c3e142 to
d55d602
Compare
Member
Author
|
Thanks @carenas! That's a good testcase, I've added it to my PR. |
NWilson
force-pushed
the
user/niwilson/fix-lookbehind-eclass
branch
from
August 23, 2026 19:47
d55d602 to
fe6851c
Compare
carenas
approved these changes
Aug 23, 2026
carenas
left a comment
Contributor
There was a problem hiding this comment.
the Perl compatible extended class syntax test could have gone to test1 as was originally suggested, though
Member
Author
|
Most of the perl eclass tests are in testinput2. I put it with the existing block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in #959