Skip to content

fix stale byte in negated glob class with glob_no_wild_separator #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sage-mode-hunter wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

fix stale byte in negated glob class with glob_no_wild_separator #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pcre2_convert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,9 +679,10 @@ if (*pattern == CHAR_EXCLAMATION_MARK
len++;
}
out->out_str[len] = (uint8_t) separator;
len++;
}

convert_glob_write_str(out, len + 1);
convert_glob_write_str(out, len);
}
else
convert_glob_write(out, CHAR_LEFT_SQUARE_BRACKET);
Expand Down
6 changes: 6 additions & 0 deletions testdata/testinput24
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,12 @@

/??a??/

/[!a]/

/[^xy]/

/a*[!b]/

#pattern convert=unset
#pattern convert=glob,convert_glob_escape=0

Expand Down
9 changes: 9 additions & 0 deletions testdata/testoutput24
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,15 @@ No match
/??a??/
(?s)\A..a..\z

/[!a]/
(?s)\A[^a]\z

/[^xy]/
(?s)\A[^xy]\z

/a*[!b]/
(?s)\Aa(*COMMIT).*?[^b]\z

#pattern convert=unset
#pattern convert=glob,convert_glob_escape=0

Expand Down
Loading