fix(where): Places matches the site, and places can be made in place - #737
Merged
Conversation
Style The page used a mat-list; every comparable page in the app uses a card grid with an accent bar, skeleton loaders and a dashed empty state. It now matches Geofences, which is the closest sibling. The pin appears as the first card rather than a banner above the list, because it IS a place — the unnamed one every alert falls back to — and a separate treatment said otherwise. Its accent and icon are muted, since it is the fallback and not a choice. Dead end The scope picker's empty state read "Add one from the location menu", naming a menu removed when Places became a page. Wrong in all eleven locales. Rather than just correct the words, the select now ends with Add a place: it opens the map picker, asks for a name, saves and selects it. Creating a place is only ever wanted at that exact moment, and sending someone to another screen lost the alarm they were mid-edit on — thirteen steps across two contexts, down to eight in one. Also added a check that reads the keys templates ask for and asserts each exists in en.json, then that every locale carries them. Parity against English cannot catch a key English is missing too, which is how NAV.PLACES went absent from all eleven. It reports two pre-existing gaps, COMMON.ERROR and COMMON.SAVED, left alone here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from review of #736.
Style
The Places page used a
mat-list. Every comparable page — Geofences especially — uses a card grid with an accent bar, skeleton loaders and a dashed empty state. It now matches.One deliberate change beyond matching: the pin is the first card in the grid, not a banner above the list. It is a place, the unnamed one every alert falls back to, and giving it a separate treatment said it was a different kind of thing. Its accent and icon are muted, because it is the fallback rather than something you chose.
The dead end
The scope picker's empty state read "Add one from the location menu" — naming a menu that #736 removed. Wrong in all eleven locales.
Correcting the words would have missed the point. The "measured from" select now ends with Add a place, which opens the map picker, asks for a name, saves it and selects it. Creating a place is only ever wanted at that exact moment, and sending someone to another screen lost the alarm they were editing: thirteen steps across two contexts, now eight in one.
An i18n check that works
Added a check that collects the keys templates actually ask for and asserts each exists in
en.json, then that every locale carries them.The parity check I had been running compares locales against English, which cannot catch a key English is missing too — which is exactly how
NAV.PLACESended up absent from all eleven files while the check reported no gaps. The new one reports two pre-existing gaps,COMMON.ERRORandCOMMON.SAVED, used by the invasion, max-battle and quest add dialogs. Left alone rather than widening this PR, but they are live snackbars rendering raw keys.Build clean, 1031 tests passing.