refactor(where): Areas and Places are one surface - #738
Merged
Conversation
Three design reviews, run independently, all reached the same objection to the nav item I added yesterday: Places is a thin, set-and-forget list that bought permanent nav space, and the pin and the named places were still on two different pages. The cross-link I added from the Areas page was the tell — it existed because the content was in the wrong place. - The Places page becomes a section of the Areas page, directly under the Location card that holds the pin. It no longer renders a pin card of its own; the card above it is the pin. - One nav item, relabelled Areas & Places, replacing two. The page title matches. /places redirects rather than 404s. - The notification language block moved from the middle of the page to the end. It has nothing to do with areas and was interrupting the picker. Two of the three reviews argued AGAINST merging Areas and My Geofences, and the third named that as the strongest counter to its own proposal, so Geofences stays its own item. It hosts drawing, submit-for-review and approval states: a workspace, not a list. Left undone deliberately: Areas and My Geofences both edit profiles.area through different controls, chips on one page and slide toggles on the other. Verified rather than taken on trust. That is a deeper incoherence than anything this change touches and wants its own decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverses the nav item from #736, after three independent design reviews all objected to it.
What they found
Unanimous: Places should not be its own nav item. It is a thin, set-and-forget list that bought permanent nav space, and the pin and named places were still on two different pages. The sharpest version, which I think is right: my own justification convicted the result. I argued Places belongs with Areas because the Location card already holds the pin and named points are more pins. That argument lands on putting places inside that page, not beside it in the nav. The
routerLink="/places"I added was the tell — a cross-link exists because the content is in the wrong place.Two of three argued against merging Areas and My Geofences, and the third named it as the strongest counter to its own proposal. Geofences hosts drawing, submit-for-review and approval states: a workspace, not a list. It stays its own item.
Changes
/placesredirects rather than 404s, so bookmarks land somewhere useful.Left undone, deliberately
Areas and My Geofences both edit the same
profiles.arealist through different controls: removable chips on one page, slide toggles on the other, both landing inAddAreaToActiveProfileAsync. I verified that rather than take it on trust.That is a deeper incoherence than anything this PR touches, it predates all of this work, and it wants its own decision rather than being folded in here.
Build clean, 1031 tests passing, no locale gaps.