Refactor/#207 멘토 지도 활동 API를 ContestMember 도메인으로 통합 - #212
Open
pykido wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "Refactor/#207_\uba58\ud1a0-\ub2f4\ub2f9-\ud504\ub85c\uc81d\ud2b8-\uc870\ud68c-API-\ucee8\ubca4\uc158-\uc218\uc815"
Open
Conversation
sjmoon00
reviewed
Jul 25, 2026
sjmoon00
left a comment
sjmoon00
left a comment
Contributor
There was a problem hiding this comment.
수고하셨습니다~
전체적으로 로직은 그대로 옮긴 순수 리팩터링이라 기능적으로 문제는 없어 보이네요
Comment on lines
+242
to
+245
| private Map<Long, String> trackNameMap(final Long contestId) { | ||
| return contestTrackConvenience.getValidateExistTracks(contestId).stream() | ||
| .collect(Collectors.toMap(ContestTrack::getId, ContestTrack::getTrackName)); | ||
| } |
Contributor
There was a problem hiding this comment.
이 트랙명 매핑 로직이 ContestQueryService.getTeamSubmissions()에도 거의 그대로 있던데 convenience쪽에 하나 만들면 어떨까요?
Comment on lines
+243
to
+248
| void 선택한_대회의_담당_팀_목록을_조회한다() { | ||
| final List<MentorProjectResponse> teams = | ||
| contestMemberQueryService.getMentorContestTeams(contest.getId(), professor); | ||
|
|
||
| assertThat(teams).hasSize(2); | ||
|
|
Contributor
There was a problem hiding this comment.
멘토 관련 조회 테스트들이 병합되면서 다 professor 로 호출되는것 같습니다.
멘토로 도는 테스트 케이스 다시 추가하면 좋을것 같습니다~
JJimini
approved these changes
Jul 26, 2026
JJimini
left a comment
JJimini
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 성재님 리뷰 반영하신 후에 머지하시면 될 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 연관된 이슈
close: #207
📜 작업 내용
MentorController·MentorQueryService를 삭제하고 멘토 지도 활동 조회 API를ContestMember도메인으로 통합했습니다.GET /mentors/me/contests,GET /mentors/me/contests/{contestId}/teams,GET /mentors/me/contests/{contestId}/teams/{teamId}/submissions)를ContestMemberController로 이동ContestMemberQueryService로 그대로 이동ContestMemberController는 클래스 레벨@RequestMapping을 제거하고 메서드별 전체 경로를 사용하도록 변경했습니다. (MemberController와 동일한 방식, 기존 관리자용 staff API URL은 모두 동일)ROLE_외부멘토/ROLE_교수) 변경 없음 — 프론트 영향과 기능 변화가 없는 순수 구조 리팩터링입니다.MentorQueryServiceTest→ContestMemberQueryServiceTest,MentorApiDocsTest→ContestMemberApiDocsTestmentor.adoc문서는 변경이 없습니다.💬 리뷰 요구사항
✨ 기타