fix negation in decimal language - #90
Open
imirkin wants to merge 2 commits into
Open
Conversation
Author
|
I've since made a few more fixes to the decimal language. But not seeing any response here, perhaps these issues aren't of concern? i.e. should I rebase + add some additional fixes? or close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happened to notice this by inspection.
I was even getting some weird errors with just a plain "-1", since I suspect this gets parsed as a negate on the literal "1", but I didn't check too deep into it. But my initial concern was about precision, so I've added a test to that effect as well.