fix(nist-ir): ship SOC Analysis_V3 without aiTask nodes - #1050
Merged
Conversation
aiTasks cannot ship as pack content and crash the Package Manager's demisto-sdk 1.38.14. Replaced with the tenant-verified copy; DCs add the aiTask per-tenant and bind it to their own prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiTasknodes cannot ship as pack content — the SDK cannot export them and the public API cannot reach them, so they are tenant-only and un-versioned. They also crash SOCFWPackManager, which installs viademisto-sdk upload_content_entityinsidedemisto/demisto-sdk:1.38.14(pydantic: aiTask not a valid enumeration member). That is what forced the v1.8.0 pin in #1048.This replaces
SOC Analysis_V3with the tenant-verified copy: 23 tasks -> 15, no aiTask nodes. DCs add the aiTask per-tenant and bind it to their own prompt, sinceaiTaskIdis tenant-local and does not travel.system: truerestored — the tenant export does not carry it andnormalize_contribution.pydoes not add it back.Verified on a tenant
Gate green with upload against both deathstar and brumxdr. Confirmed landed on brumxdr by downloading the playbook back (15 tasks, no aiTask).
Replayed
scenarios/turla_carbon_abnormal_mde.yml(1 Abnormal + 144 Defender) on deathstar withSOCExecutionList_V3ondefault:abnormal_security_email_protection_raw,msft_graph_security_alerts_rawsoc-get-email-forensicsfired once on the Email branchsoc-enrich-endpoint,soc-enrich-user,soc-enrich-device-logons,soc-enrich-file(success)completedNot proven
shadow_mode_stateisnot_applicablethroughout — shadow mode is not exercised by this change.integration_unavailablerows are the expected no-integration path (Unsupported Command (23)).Behaviour change to be aware of
SaaS and Workload branches are not present in this copy, so alerts in those categories fall through
Product Categoryto#default#. Deliberate, and independent of the aiTask issue.