fix(i18n): dedupe funds.amount_range, align zh/tr placeholders, theme token - #23
Merged
Merged
Conversation
Contributor
Author
Review — ready to mergeIndependent i18n/theme fix: dedupes \ unds.amount_range, aligns zh/tr placeholders, uses \�ar(--bg)\ on the Stripe element. Sugestia: można mergować niezależnie. |
Owner
|
Thank you for the i18n/theme cleanup. We just merged the first clean batch into main: #16 (client delete), #24 (invoice number display), #13 (Tpay), #22 (addon settings framework) and #14 (tax rewrite). This small fix now conflicts with main because the client language files and the invoice view moved under the merged PRs. A quick rebase on the updated main and it's ready. Appreciated. |
hedon77
force-pushed
the
fix/core-test-fixes
branch
from
September 1, 2026 19:39
49afc49 to
fdf9020
Compare
Contributor
Author
|
*Zrebasowane na aktualny \main* — gałąź merguje się teraz czysto, konflikt zniesiony. Gotowe do merga. |
Panelica
pushed a commit
that referenced
this pull request
Sep 3, 2026
The zh files had drifted from English after several merges (#9, #14, #17, #21, #23): same keys, but flattened/reordered, so the zh structure test failed. Rebuild admin/client/common/messages to English's exact nesting and order, keeping every existing Chinese translation. Also fix funds.amount_range, which carried :min/:max placeholders English does not pass, so it rendered the raw tokens; it now matches the English static form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Fixes the translation duplicate-key and Simplified Chinese parity failures, plus the client theme-token audit.