Implement create match between two members for a match cycle - #86
Draft
rootandroo wants to merge 1 commit into
Draft
Implement create match between two members for a match cycle#86rootandroo wants to merge 1 commit into
rootandroo wants to merge 1 commit into
Conversation
This was referenced Aug 24, 2026
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/admin/matches— admin endpoint to create a match between two members for a match cycle.MatchService(defaults status toPENDING, derivesYYYY-MMmonth label from the cycle'srunAt),CreateMatchRequest/AdminMatchResponseDTOs, andMatchCycleNotFoundExceptionmapped to 404.Testing
MatchServiceTest(3 tests): success, status defaulting, cycle-not-found guard.AdminMatchControllerTest(3 MockMvc tests): 200 envelope, validation 400, cycle-missing 404.just backend-test(spotless + checkstyle) green on this branch.Part of the per-endpoint match-domain stack; repo layer comes from #74.