Updates to improve input demo documentation - #4035
Open
abbylewis wants to merge 13 commits into
Open
Conversation
abbylewis
commented
Jun 24, 2026
abbylewis
commented
Jun 24, 2026
infotroph
approved these changes
Jun 25, 2026
infotroph
left a comment
Member
There was a problem hiding this comment.
Thanks! I agree this is a big improvement. I left a few suggestions throughout, mostly with wording suggestions you can modify or reject freely.
Comment on lines
4
to
5
| - "Aritra Dey" | ||
| - "David LeBauer" |
Member
There was a problem hiding this comment.
At this point you've modified the source demo enough that it's probably appropriate to list yourself as the sole author and credit previous work with wording something like "This demo is patterned after PEcAn demo 1 (link here), which was written by Aritra Dey and David LeBauer". @AritraDey-Dev and @dlebauer does that make sense to y'all?
| select("site_id", "run_id", "posix", "CH4_flux") |> | ||
| ggplot() + | ||
| aes(x = posix, | ||
| y = CH4_flux * 1E6 * 60 * 60 * 24, # Convert from kg/m2/s to mg/m2/d |
Member
There was a problem hiding this comment.
Same suggestion to use ud_convert here as above
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
infotroph
reviewed
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the PEPRMT demos, including:
@infotroph not huge updates, but I think this should be helpful for CARB/etc to understand what's happening in the demos
Review Time Estimate
Types of changes
Checklist: