v4: match payment observations safely - #48
Merged
Conversation
Phloraxx
force-pushed
the
v4/notification-normalization
branch
from
September 1, 2026 04:24
595f456 to
37b188e
Compare
Phloraxx
force-pushed
the
v4/observation-matching
branch
from
September 1, 2026 04:24
765494f to
a802b78
Compare
Phloraxx
marked this pull request as ready for review
September 1, 2026 05:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Sixth stacked PayGate v4 implementation slice. Depends on PR #47.
Implements
BEGIN IMMEDIATESQLite transactionpayment_observationsrows for matched, unmatched and ambiguous Activitynotification_posted_atafter exact-amount reuse fails closed as ambiguousserver_received_atis treated as low-confidence after reusenamepayment.paidhistory + webhook outbox + payment mutation + observation are atomicTests
Covers pending→paid, relay replay, duplicate observation for paid payment, delayed-after-expiry matching, before/after cancellation, reused-amount ambiguity for Kotak, trusted historical matching after reuse, and matching an older Paytm payment after new creation has switched to Kotak. Unit tests, race tests, vet and
git diff --checkpass locally.Safety
No production HTTP or Android wiring yet. Unmatched/ambiguous observations do not mutate payment state.