v4: expose merchant payment HTTP API - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Tenth stacked PayGate v4 implementation slice. Depends on PR #51.
Implements
net/httpmerchant API; still not registered into the production v3 serverPOST /v1/payments,GET /v1/payments/{id},POST /v1/payments/{id}/cancelamount, person/payeename, non-unique eventexternal_id, optional metadata andIdempotency-KeypaymentAccountupi_uri, lifecycle timestamps and statusnameTests
Covers authenticated creation, canonical UPI URI, no routing leakage, exact replay/conflict, idempotency across API-key rotation, non-unique event IDs, get/cancel/idempotent cancel, missing/revoked auth, rejected
paymentAccount, missing idempotency key, fractional/trailing JSON rejection, 404s, and paid payer-identity response. Fullinternal/v4/...unit tests, race tests, vet and diff checks pass locally.Safety
No production route registration, no PocketBase changes and no frontend cutover yet.