Skip to content

Switch SAM2 point-query Objectives to the model bundle manifest - #833

Draft
griswaldbrooks wants to merge 1 commit into
mainfrom
fm/moveitpro-ml10-d4-sam2-objectives
Draft

Switch SAM2 point-query Objectives to the model bundle manifest#833
griswaldbrooks wants to merge 1 commit into
mainfrom
fm/moveitpro-ml10-d4-sam2-objectives

Conversation

@griswaldbrooks

Copy link
Copy Markdown

[written by AI]

needs: moveit_pro/#21156

Motivation

moveit_pro#21156 migrates
GetMasks2DFromPointQuery onto the pooled model runtime, replacing its encoder_model_path /
decoder_model_path ports with model_bundle_manifest + runtime_id. Nine Objective files in this
workspace (13 sites) still set the removed ports, so they fail to load against that PR's image.

Same shape as #802 (SAM3) and #831 (SAM2 automasking); this is the SAM2 point-query flavor.

Brief description

  • Seven direct/subtree call sites (kitchen_sim ×4, lab_sim, hangar_sim ×2): the two *_model_path
    attributes become model_bundle_manifest="models/model.yaml" + runtime_id="onnxruntime".
    model_package="moveit_pro_sam2" is unchanged.
  • Two picknik_ur_base_config subtrees (segment_image_from_point_subtree,
    segment_point_cloud_from_clicked_point_subtree): tree defaults, call-site passthroughs, and the
    TreeNodesModel inout_port declarations all swap to the new port names, so no dead port
    declarations remain.

The manifest itself ships in the moveit_pro_sam2 submodule via
moveit_pro_sam2#3; the submodule bump
rides on #832 and is not duplicated here.

SAM3 (GetMasks2DFromExemplar) and SAM2 automasking usages are untouched — they belong to #802 and
#831.

How it was tested

  • All nine edited files parse as well-formed XML; prettier (with @prettier/plugin-xml, repo
    settings) reports no formatting change.
  • Repo-wide grep confirms no GetMasks2DFromPointQuery site still sets a *_model_path port, and
    that no other SAM2-point-query port declarations were missed.
  • Full-stack validation is this PR's CI, which builds against moveit_pro#21156's image via the
    needs: token.

Release notes

None

…le manifest

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f004541-dfc7-4c67-a282-55f8b1b83f83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant