Switch SAM2 point-query Objectives to the model bundle manifest - #833
Draft
griswaldbrooks wants to merge 1 commit into
Draft
Switch SAM2 point-query Objectives to the model bundle manifest#833griswaldbrooks wants to merge 1 commit into
griswaldbrooks wants to merge 1 commit into
Conversation
…le manifest Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
needs: moveit_pro/#21156
Motivation
moveit_pro#21156 migrates
GetMasks2DFromPointQueryonto the pooled model runtime, replacing itsencoder_model_path/decoder_model_pathports withmodel_bundle_manifest+runtime_id. Nine Objective files in thisworkspace (13 sites) still set the removed ports, so they fail to load against that PR's image.
Same shape as #802 (SAM3) and #831 (SAM2 automasking); this is the SAM2 point-query flavor.
Brief description
*_model_pathattributes become
model_bundle_manifest="models/model.yaml"+runtime_id="onnxruntime".model_package="moveit_pro_sam2"is unchanged.picknik_ur_base_configsubtrees (segment_image_from_point_subtree,segment_point_cloud_from_clicked_point_subtree): tree defaults, call-site passthroughs, and theTreeNodesModelinout_portdeclarations all swap to the new port names, so no dead portdeclarations remain.
The manifest itself ships in the
moveit_pro_sam2submodule viamoveit_pro_sam2#3; the submodule bump
rides on #832 and is not duplicated here.
SAM3 (
GetMasks2DFromExemplar) and SAM2 automasking usages are untouched — they belong to #802 and#831.
How it was tested
@prettier/plugin-xml, reposettings) reports no formatting change.
GetMasks2DFromPointQuerysite still sets a*_model_pathport, andthat no other SAM2-point-query port declarations were missed.
needs:token.Release notes
None