π‘οΈ Sentinel: [HIGH] Fix hardcoded JWT secret fallback in AuthService - #1
π‘οΈ Sentinel: [HIGH] Fix hardcoded JWT secret fallback in AuthService#1Pmaster-dev wants to merge 1 commit into
Conversation
β¦default Enforce process.env.JWT_SECRET requirement in production environment in AuthService constructor to prevent token forgery vulnerabilities. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel PR: Fix hardcoded JWT secret fallback
π¨ Severity: HIGH
π‘ Vulnerability:
server/services/AuthService.tsfell back to a hardcoded default string ("negrarosa-inclusive-security-framework-secret") whenprocess.env.JWT_SECRETwas undefined.π― Impact: Attackers aware of the default secret could forge JWT tokens to impersonate users and bypass authentication.
π§ Fix: Updated
AuthServiceconstructor to throw a critical error ifJWT_SECRETis missing in production (NODE_ENV === "production"), and updated the dev fallback secret to explicitly indicate development-only usage.β Verification: Tested constructor instantiation under
developmentandproductionenvironments via tsx node script to verify runtime guard behavior.PR created automatically by Jules for task 1298358912787598792 started by @Pmaster-dev