⚡ Bolt: eliminate N+1 query loop when fetching all webhooks - #2
⚡ Bolt: eliminate N+1 query loop when fetching all webhooks#2Pmaster-dev wants to merge 1 commit into
Conversation
Add getAllWebhooks() to storage layer to replace sequential user iteration loops in routes, background task export, and analytics. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
getAllWebhooks()toIStorageandMemStorage, and replaced sequentialstorage.getAllUsers()+storage.getWebhooksByUserId(user.id)loops inserver/routes.ts,BackgroundTaskService.ts, andWebhookDataService.ts.🎯 Why: Querying all webhooks formerly executed$1 + N$ async operations (fetching all users and looping over each user id to filter webhooks).
📊 Impact: Reduces query time complexity from$O(N \cdot W)$ with $1 + N$ async roundtrips to $O(W)$ with a single storage operation.
🔬 Measurement: Tested via integration test suite (
node test-why-submissions.js) and verified/api/webhooksand/api/webhooks/export-csvAPI endpoints.PR created automatically by Jules for task 8776738288295971130 started by @Pmaster-dev